Bump compose-go to v2 #3117
Merged
Bump compose-go to v2 #3117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apostasie
force-pushed
the
dev-compose-v2
branch
from
96ffec9
to
b8ef3ae
Compare
|
This is not too bad. TBD
|
apostasie
force-pushed
the
dev-compose-v2
branch
3 times, most recently
from
08029a0
to
7486d6d
Compare
|
Feel like this one could go in or do we need some form of soak time? Appreciate this is a "big" change (not many lines of code / not complex, but certainly impactful). IMHO we should go for it and not stay behind longer (we can fix bugs as they come) - it will obviously only get worse the more we wait. |
AkihiroSuda
reviewed
Jun 20, 2024
Signed-off-by: apostasie <spam_blackhole@farcloser.world>
apostasie
force-pushed
the
dev-compose-v2
branch
from
7486d6d
to
9755298
Compare
|
@AkihiroSuda fixed the bizarro change in compose wrt host/ip. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.