CI/test fixing #3402
Merged
CI/test fixing #3402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apostasie
commented
Sep 3, 2024
| } | ||
|
|
||
| tearDown := func() { | ||
| base.Cmd("rmi", "-f", img).AssertOK() |
There was a problem hiding this comment.
Make sure we cleanup the image once done.
apostasie
commented
Sep 3, 2024
| fb, err := os.ReadFile(output) | ||
| assert.NilError(t, err) | ||
|
|
||
| assert.Assert(t, strings.Contains(string(fb), fmt.Sprintf("Loaded image: %s:latest", img))) | ||
| base.Cmd("images").AssertOutContains(testutil.ImageRepo(testutil.CommonImage)) |
There was a problem hiding this comment.
I do not understand what that was supposed to test.
It makes much more sense to me that we testing the fact the loaded image (with custom tag) is there, instead of testing what we know is there already...
Am I missing something here?
apostasie
force-pushed
the
ci-fix-tests
branch
from
54e7c31
to
64b4f6e
Compare
|
CI failures are:
|
This was referenced Sep 4, 2024
Draft
|
Thanks, but commit messages should explain what failure was fixed |
…ng prune Signed-off-by: apostasie <spam_blackhole@farcloser.world>
apostasie
force-pushed
the
ci-fix-tests
branch
from
64b4f6e
to
9e975ae
Compare
…ootless Signed-off-by: apostasie <spam_blackhole@farcloser.world>
apostasie
force-pushed
the
ci-fix-tests
branch
from
9e975ae
to
935ee8a
Compare
Fair enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny commits enhancing our test situation - making sure we do cleanup resources once done, to avoid polluting other tests expecting a clean slate.
Fix #3403
@AkihiroSuda can we get this in? (see question inline though)