-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nerdctl image (encrypt|decrypt) SRC DST
#484
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'd like to have this in v0.13, but can be postponed to v0.14. |
AkihiroSuda
force-pushed
the
imgcrypt
branch
2 times, most recently
from
November 1, 2021 11:30
3aa522f
to
adc7160
Compare
stefanberger
suggested changes
Nov 1, 2021
lumjjb
approved these changes
Nov 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks awesome! LGTM with Stefan's feedback
AkihiroSuda
force-pushed
the
imgcrypt
branch
5 times, most recently
from
November 2, 2021 01:24
b7faabb
to
d7cc941
Compare
ktock
reviewed
Nov 2, 2021
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
…bility Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
ktock
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (except typo)
AkihiroSuda
force-pushed
the
imgcrypt
branch
2 times, most recently
from
November 2, 2021 02:06
f0d6e37
to
27dd90a
Compare
ktock
approved these changes
Nov 2, 2021
Encrypt: openssl genrsa -out mykey.pem openssl rsa -in mykey.pem -pubout -out mypubkey.pem nerdctl image encrypt --recipient=jwe:mypubkey.pem --platform=linux/amd64,linux/arm64 foo example.com/foo:encrypted nerdctl push example.com/foo:encrypted Decrypt: nerdctl pull --unpack=false example.com/foo:encrypted nerdctl decrypt --key=mykey.pem example.com/foo:encrypted foo:decrypted See also ./docs/ocicrypt.md Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nerdctl run
has been supporting decryption, but we didn't have the command to encrypt images.This will be probably beneficial for IPFS (#465)
Encrypt:
Decrypt:
See also
docs/ocicrypt.md
nerctl image encrypt
nerctl image decrypt