rootless: allow loading an existing AppArmor profile #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkihiroSuda
force-pushed
the
dev-apparmor
branch
from
78f4996
to
2e5e07e
Compare
AkihiroSuda
force-pushed
the
dev-apparmor
branch
from
2e5e07e
to
a88f558
Compare
AkihiroSuda
force-pushed
the
dev-apparmor
branch
from
a88f558
to
be59737
Compare
nerdctl run --- Rootless nerdctl now applies the `nerdctl-default` profile to containers by default, if it is already loaded with `sudo nerdctl apparmor load`. Still defaults to "unconfined" when the profile is not loaded. nerdctl info --- Now `nerdctl info` shows "apparmor" when the AppArmor kernel module is enabled, regardless to whether the `nerdctl-default` profile is loaded or not. When the profile is not available, `nerdctl info` shows a warning message. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
AkihiroSuda
force-pushed
the
dev-apparmor
branch
from
be59737
to
e8ac71b
Compare
ktock
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nerdctl run
Rootless nerdctl now applies the
nerdctl-defaultprofile to containers by default, if it is already loaded withsudo nerdctl apparmor load.Still defaults to "unconfined" when the profile is not loaded.
nerdctl info
Now
nerdctl infoshows "apparmor" when the AppArmor kernel module is enabled, regardless to whether thenerdctl-defaultprofile is loaded or not.When the profile is not available,
nerdctl infoshows a warning message.Fix #507