Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs + nits #517

Merged
merged 5 commits into from
Nov 17, 2021
Merged

Conversation

AkihiroSuda
Copy link
Member

@AkihiroSuda AkihiroSuda commented Nov 16, 2021

Follow-up to #197 #73 #505

@AkihiroSuda AkihiroSuda added this to the vNext milestone Nov 16, 2021
@AkihiroSuda
Copy link
Member Author

cc @jsturtevant

@AkihiroSuda AkihiroSuda marked this pull request as draft November 16, 2021 08:58
@AkihiroSuda

This comment has been minimized.

@AkihiroSuda AkihiroSuda marked this pull request as ready for review November 16, 2021 09:29
@AkihiroSuda AkihiroSuda force-pushed the update-doc-20211116 branch 3 times, most recently from 7fab3dc to c3fe9b6 Compare November 16, 2021 09:32
@jsturtevant
Copy link
Contributor

lgtm

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
The `:window:` emoji isn't widely supported yet, so use `:blue_square:` instead.

I was about to use `⊞` (U+229E SQUARED PLUS), but `doctoc` doesn't seem
work well with Unicode chars.

Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
@AkihiroSuda AkihiroSuda merged commit 24168f0 into containerd:master Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants