Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adaptation: close plugin if initial synchronization fails. #103

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

klihub
Copy link
Member

@klihub klihub commented Aug 19, 2024

Close the connection to the plugin if initial synchronization fails, like we do for all other failures considered unrecoverable.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub requested a review from fuweid August 19, 2024 12:13
@klihub
Copy link
Member Author

klihub commented Aug 19, 2024

/cc @yylt

@klihub klihub requested a review from mikebrow August 19, 2024 12:15
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nit to add a bit more clarity

pkg/adaptation/plugin.go Show resolved Hide resolved
@mikebrow mikebrow added this to the 1.0 milestone Aug 19, 2024
Co-authored-by: Mike Brown <brownwm@us.ibm.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Copy link
Member

@mikebrow mikebrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yylt
Copy link
Contributor

yylt commented Aug 23, 2024

/cc @AkihiroSuda

@fuweid fuweid merged commit 53760d4 into containerd:main Aug 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants