Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cri image service proxy mode for getting registry auth #282

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Support cri image service proxy mode for getting registry auth #282

merged 1 commit into from
Dec 14, 2022

Conversation

darfux
Copy link
Contributor

@darfux darfux commented Dec 12, 2022

Support cri based authentication like stargz-snapshotter (https://github.com/containerd/stargz-snapshotter/blob/main/docs/overview.md#cri-based-authentication). The proxy service uses the implementation by stargz directly.

Fixes: #47

Signed-off-by: Li Yuxuan liyuxuan.darfux@bytedance.com

@imeoer
Copy link
Collaborator

imeoer commented Dec 13, 2022

Hi @darfux , thanks for the PR, others LGTM! Now we have 3 main ways to get the auth (label not recommend), are you interested in adding some doc about theirs?

@darfux
Copy link
Contributor Author

darfux commented Dec 13, 2022

Hi @darfux , thanks for the PR, others LGTM! Now we have 3 main ways to get the auth (label not recommend), are you interested in adding some doc about theirs?

@imeoer Sounds good, I'll work for it 😀

@changweige
Copy link
Member

Sorry, need rebase

changweige
changweige reviewed Dec 13, 2022
View reviewed changes
pkg/auth/image_proxy.go Outdated Show resolved Hide resolved
@changweige
Copy link
Member

changweige commented Dec 13, 2022 •
edited
Loading

Fortunately, @liubin helps add an e2e test based on KinD #283 . Could you please also add a test case based on the K8s e2e test framework after Bin's PR is merged?

@darfux darfux force-pushed the support-cri-auth branch 3 times, most recently from f6acac4 to 1cb76ab Compare December 13, 2022 07:28
@darfux
Copy link
Contributor Author

darfux commented Dec 13, 2022

Hi @imeoer @changweige , I've added auth related doc to docs/configure_nydus.md and resolved reviews above. Now is waiting the e2e framework PR to be merged and then I'll try to add an e2e test

@changweige
Copy link
Member

Hi @imeoer @changweige , I've added auth related doc to docs/configure_nydus.md and resolved reviews above. Now is waiting the e2e framework PR to be merged and then I'll try to add an e2e test

Thanks, this feature is helpful, I just experienced the feature locally. Otherwise, it looks good to me.

@changweige
Copy link
Member

@darfux The k8s e2e test framework has been merged

@changweige
Copy link
Member

Sorry, need another rebase 🤣. Then let's merge it first and raise another PR to add K8s e2e test

@darfux
Support cri image service proxy mode for getting registry auth
9ddfe16 
Support cri based authentication like stargz-snapshotter
(https://github.com/containerd/stargz-snapshotter/blob/main/docs/overview.md#cri-based-authentication).
The proxy service uses the implementation by stargz directly.

Fixes: containerd#47

Signed-off-by: Li Yuxuan <liyuxuan.darfux@bytedance.com>
@changweige changweige merged commit 83c114b into containerd:main Dec 14, 2022
@darfux darfux deleted the support-cri-auth branch December 14, 2022 13:04
@darfux darfux mentioned this pull request Dec 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imeoer imeoer imeoer left review comments

@changweige changweige changweige approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support cri image service proxy mode for getting registry auth
3 participants
@darfux @imeoer @changweige