Invite Yan Song as nydus-snapshotter committer #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Yan Song as a committer Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
eryugey
approved these changes
Jan 18, 2023
imeoer
approved these changes
Jan 18, 2023
Codecov ReportBase: 29.53% // Head: 29.53% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
=======================================
Coverage 29.53% 29.53%
=======================================
Files 37 37
Lines 3718 3718
=======================================
Hits 1098 1098
Misses 2500 2500
Partials 120 120 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Thanks @changweige ! |
ktock
approved these changes
Jan 18, 2023
|
@imeoer you can try to click the button to join the sub-team. I don't have permission to add people but the join-request can be approved by admin. And welcome (again) ! |
|
Thanks @changweige @fuweid, I can't seem to open the @containerd/nydus-committers page (with 404), waiting for admin to add me. |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yan Song @imeoer has worked for nydus-snapshotter reviewer for half a year and is eager to review many PRs and gave a number of remarkable PR comments, which is a great promotion for the project. He also contributed many patches and features to the nydus-snapshotter project, especially in the field of nydus container image build which has already been integrated into
nerdctlandBuildkit, and proposed some meaningful ideas to help the project grow.I'd like to invite him as a nydus-snapshotter committer if he would approve :)
Needs explicit LGTM from @imeoer and 1/3 of the nydus-snapshotter committers: