assign root dir in the first place when filling up defaults #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As other default value may depend on root dir. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Codecov ReportBase: 29.53% // Head: 29.53% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #328 +/- ##
=======================================
Coverage 29.53% 29.53%
=======================================
Files 37 37
Lines 3718 3718
=======================================
Hits 1098 1098
Misses 2500 2500
Partials 120 120
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
imeoer
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As other default value may depend on root dir.
Signed-off-by: Changwei Ge gechangwei@bytedance.com