Back port some stable patches for v0.5.x #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a race that multiple goroutines can all WaitUntilState() at the same time and waiting for the same expected state. So they can both escape from the very beginning state check ending up with an extra event record. Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
go race detected
==================
WARNING: DATA RACE
Read at 0x00c0000bed48 by goroutine 34:
github.com/containerd/nydus-snapshotter/pkg/metrics/collector.(*DaemonInfoCollector).Collect()
/home/runner/work/nydus-snapshotter/nydus-snapshotter/pkg/metrics/collector/daemon.go:33 +0x78
github.com/containerd/nydus-snapshotter/pkg/manager.(*Manager).handleDaemonDeathEvent()
/home/runner/work/nydus-snapshotter/nydus-snapshotter/pkg/manager/manager.go:314 +0x212
github.com/containerd/nydus-snapshotter/pkg/manager.NewManager.func1()
/home/runner/work/nydus-snapshotter/nydus-snapshotter/pkg/manager/manager.go:364 +0x39
Previous write at 0x00c0000bed48 by goroutine 88:
github.com/containerd/nydus-snapshotter/pkg/manager.(*Manager).StartDaemon.func2()
/home/runner/work/nydus-snapshotter/nydus-snapshotter/pkg/manager/daemon_adaptor.go:97 +0x5d3
Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
sctb512
reviewed
Jan 19, 2023
| d.Lock() | ||
| collector.NewDaemonInfoCollector(&d.Version, -1).Collect() |
There was a problem hiding this comment.
Whether is a lock needed before another call to this method?
There was a problem hiding this comment.
In a few cases, I get the extra values that d.version is incorrect. However, the value of the expected version is eventually correct.
There was a problem hiding this comment.
What do you mean by "incorrect"? The version string is shorter than expected or polluted?
There was a problem hiding this comment.
The version string is null. It appeared by chance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clearly pick some stable patches for v0.5 and prepare to release v0.5.1