Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

let systemd service adapt the new toml configuration #340

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

changweige
Copy link
Member

@changweige changweige commented Jan 31, 2023

Let nydusd have a minimal number of parameters when being started by systemd.

Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Copy link
Member

@sctb512 sctb512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@imeoer
Copy link
Collaborator

imeoer commented Feb 2, 2023

LGTM, please also help to update other docs (in the image-service repo) after release.

@changweige
Copy link
Member Author

LGTM, please also help to update other docs (in the image-service repo) after release.

Sure. Will raise an according PR later. Can you merge the PR?

@imeoer imeoer merged commit 089c6f5 into containerd:main Feb 3, 2023
@changweige changweige deleted the impr-systemd branch February 6, 2023 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants