enable system controller config #345
Conversation
Codecov ReportBase: 28.25% // Head: 28.21% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
==========================================
- Coverage 28.25% 28.21% -0.04%
==========================================
Files 37 37
Lines 3667 3672 +5
==========================================
Hits 1036 1036
- Misses 2510 2515 +5
Partials 121 121
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
changweige
force-pushed
the
enhance-system-controller
branch
from
d651b4c
to
3f192b4
Compare
| enable = true | ||
|
|
||
| [system.debug] | ||
| daemon_cpu_profile_duration_secs = 5 |
There was a problem hiding this comment.
Shall we add a comment for this item in toml file?
snapshot/snapshot.go
Outdated
| @@ -122,7 +122,7 @@ func NewSnapshotter(ctx context.Context, cfg *config.SnapshotterConfig) (snapsho | |||
| }() | |||
| } | |||
|
|
|||
| if cfg.EnableSystemController { | |||
| if config.SystemControllerEnabled() { | |||
There was a problem hiding this comment.
Maybe IsSystemControllerEnabled or GetSystemControllerEnabled is better to understand?
| # Whether tp enable stargz support | ||
| enable_stargz = false | ||
| # Whether snapshotter should try to clean up resources when it is closed | ||
| cleanup_on_close = false | ||
|
|
||
| [system] | ||
| # Snapshotter's debug and trace HTTP server interface |
There was a problem hiding this comment.
Can the interface address be configurated? Should be documented here.
There was a problem hiding this comment.
Good point. This PR now includes changes that add the config entry to customize the system controller address path
1. move system controller config to a dedicated struct 2. capable of configuring daemon cpu profile duration. 3. capable of configuring system controller address path Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
changweige
force-pushed
the
enhance-system-controller
branch
from
3f192b4
to
356cc07
Compare
Signed-off-by: Changwei Ge gechangwei@bytedance.com