Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up project folder layout #396

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

changweige
Copy link
Member

Move some package to internal folder, which won't be exported

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.07 🎉

Comparison is base (d925eb5) 27.88% compared to head (4da02ba) 27.96%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
+ Coverage   27.88%   27.96%   +0.07%     
==========================================
  Files          40       40              
  Lines        4077     4077              
==========================================
+ Hits         1137     1140       +3     
+ Misses       2801     2798       -3     
  Partials      139      139              
Impacted Files Coverage Δ
config/default.go 0.00% <ø> (ø)
internal/flags/flags.go 100.00% <ø> (ø)
internal/logging/setup.go 76.47% <ø> (ø)
config/config.go 28.94% <100.00%> (ø)
pkg/blob/blob_manager.go 32.65% <0.00%> (+3.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@gaius-qi gaius-qi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Move some package to internal folder

Signed-off-by: Changwei Ge <gechangwei@bytedance.com>
Copy link
Member

@sctb512 sctb512 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@changweige changweige merged commit 837af00 into containerd:main Mar 6, 2023
@changweige changweige deleted the cleanup-layout branch March 6, 2023 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants