-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: auto merge dependabot PRs for patch updates #188
Conversation
Signed-off-by: jiaxiao zhou <jiazho@microsoft.com>
5ad82d8
to
775e287
Compare
Does this mean that any failing CI test would prevent the auto merge? |
Just reviewed branch protection. Honestly I'm not particularly on board with auto-merging dependabot, especially knowing our CI is missing some important checks (like validating protos). |
@cpuguy83 thanks for the suggestion. I am going to create an issue for adding more CI checks like validaitng protos. It seems like this PR won't be merged in until we've done the above first. I will convert it to a draft and leave it there. |
Signed-off-by: Jiaxiao Zhou <jiazho@microsoft.com>
I still don't like auto-merging dependabot, but I wouldn't want to block it if others find it useful. |
@cpuguy83 would you please state the reasons why you don't like auto-merging dependantabot? This will help me understand the tradeoffs better. |
I am not a big fan of auto-merging because it doesn't give awareness to maintainers. I like the manual step reviewing and understanding what changed even if it takes an extra step. Even if tests pass there might be a reason not to merge (either something like missing tests or some other external reason (one example could be a library gets compromised, and we need it pinned to a particular version). In summary, I love having dependa-bot do the manually labor but like the human check before merging. |
Closing this PR |
This PR adds a new action called "Dependabot automation" which will automatically merge dependabot PRs for patch updates. According to this doc,
which means the PRs won't be auto-merged if the tests gate fails or it doesn't have the required number of reviews.
Hence I've also added
gh pr review --approve "$PR_URL
to automatically approve the dependabot PRs.Since this automates the process of merging dependabot PRs, I've set the schedule interval for depdnabot to "daily".
Close #150
Could you please take a look? @utam0k