cgroups: v2: Enable all controllers from parent #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpuguy83
force-pushed
the
fix_cg2_nesting
branch
from
24eda86
to
d9ed20c
Compare
This was referenced Dec 2, 2022
Merged
devigned
requested changes
Dec 2, 2022
The test for nested cgroups was failing for v2 cgroups because controllers have to be explicitly enabled for child cgroups. This change makes sure we enable those controllers for all parents of a nested cgroup *that we are creating*. This does not change parents that we did not create. Signed-off-by: Brian Goff <cpuguy83@gmail.com>
cpuguy83
force-pushed
the
fix_cg2_nesting
branch
from
d9ed20c
to
4a5833f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for nested cgroups was failing for v2 cgroups because controllers have to be explicitly enabled for child cgroups.
This change makes sure we enable those controllers for all parents of a nested cgroup that we are creating.
This does not change parents that we did not create.
Fixes #28