Add the shim to to the network NS specified #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsturtevant
force-pushed
the
fix-network-ns
branch
from
97cef07
to
166de9c
Compare
jprendes
reviewed
Oct 26, 2023
Signed-off-by: James Sturtevant <jstur@microsoft.com>
jsturtevant
force-pushed
the
fix-network-ns
branch
from
166de9c
to
b936b92
Compare
jprendes
approved these changes
Oct 26, 2023
This was referenced Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When removing the mounting code we also removed the network setup: #327 (comment)
Ends up this is required as youki is only setting the Pid and User namespaces: https://github.com/containers/youki/blob/ba4a10f4a09b0360eeb38ab70a95adc986b2b9da/crates/libcontainer/src/process/container_intermediate_process.rs#L70