Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change cni.dev version scheme #76

Open
1 of 2 tasks
nate-double-u opened this issue Jan 8, 2021 · 7 comments
Open
1 of 2 tasks

Change cni.dev version scheme #76

nate-double-u opened this issue Jan 8, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@nate-double-u
Copy link
Collaborator

nate-double-u commented Jan 8, 2021

I've been researching a fair amount on how to do versioning in hugo, and think that the URL scheme I set up for cni.dev is probably not the best method for this site.

A folder method of versioning cni.dev may be better for the following reasons:

  • Simpler logic for maintainers
  • No need to maintain feature branches
  • No requirement for maintainer to have access to Netlify to manage a release

A con I can think of for this method, for a site of this size, is that once you start adding languages/localizations navigation becomes more complex.


Once PR #80 is merged in, then we can:

  • Remove version feature branches here in github
  • Remove version Netlify servers
@nate-double-u nate-double-u added the enhancement New feature or request label Jan 8, 2021
@nate-double-u
Copy link
Collaborator Author

@squeed, @bboreham, @dcbw, @mccv1r0

If you're interested, I'm happy to make this update.

@squeed
Copy link
Member

squeed commented Jan 12, 2021

I think the folder method is probably the right choice; I don't see us localizing anytime soon, but we definitely will be cutting versions semi-frequently.

@nate-double-u nate-double-u self-assigned this Feb 13, 2021
nate-double-u added a commit to nate-double-u/containernetworking-cni.dev that referenced this issue Feb 17, 2021
Changing from a URL based to a folder based versioning scheme.

Fixes: containernetworking#76

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
@nate-double-u
Copy link
Collaborator Author

nate-double-u commented Feb 17, 2021

[edit] comment moved to description.

nate-double-u added a commit to nate-double-u/containernetworking-cni.dev that referenced this issue Feb 17, 2021
Changing from a URL based to a folder based versioning scheme.

Fixes: containernetworking#76

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
nate-double-u added a commit to nate-double-u/containernetworking-cni.dev that referenced this issue Feb 22, 2021
- Changing from a URL based to a folder based versioning scheme.
- Add link checker command to Makefile
- Updating navbar-version-selector's dropdown menu to link to the top level of a
  version if the specific file does not exist
- Updating links throughout

Fixes: containernetworking#76

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
nate-double-u added a commit to nate-double-u/containernetworking-cni.dev that referenced this issue Feb 22, 2021
- Changing from a URL based to a folder based versioning scheme.
- Add link checker command to Makefile
- Updating navbar-version-selector's dropdown menu to link to the top level of a
  version if the specific file does not exist
- Updating deprecation warning
- Updating links throughout

Fixes: containernetworking#76

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
nate-double-u added a commit to nate-double-u/containernetworking-cni.dev that referenced this issue Feb 22, 2021
- Changing from a URL based to a folder based versioning scheme.
- Add link checker command to Makefile
- Updating navbar-version-selector's dropdown menu to link to the top level of a
  version if the specific file does not exist
- Updating deprecation warning
- Updating links throughout

Contributes to: containernetworking#76

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
nate-double-u added a commit to nate-double-u/containernetworking-cni.dev that referenced this issue Mar 1, 2021
- Changing from a URL based to a folder based versioning scheme.
- Add link checker command to Makefile
- Updating navbar-version-selector's dropdown menu to link to the top level of a
  version if the specific file does not exist
- Updating deprecation warning
- Updating links throughout

Contributes to: containernetworking#76

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
@nate-double-u
Copy link
Collaborator Author

I don't have any analytics access -- do we know if people are visiting the previous versions now? I'm curious because we may want to change the feature branches that point to the new versions system instead of deleting them entirely -- turn them into redirects to preserve bookmarks. We maybe able to do this on the Netlify side so we don't have to maintain the feature branches here.

nate-double-u added a commit to nate-double-u/containernetworking-cni.dev that referenced this issue Mar 10, 2021
- Changing from a URL based to a folder based versioning scheme.
- Moving from 3 digit to 2 digit version number scheme
- Add link checker command to Makefile
- Updating navbar-version-selector's dropdown menu to link to the top level of a
  version if the specific file does not exist
- Updating deprecation warning
- Updating links throughout

Contributes to: containernetworking#76

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
@nate-double-u
Copy link
Collaborator Author

nate-double-u commented Mar 22, 2021

Now that PR #80 has been merged in, we can bring down the Netlify sites, and delete the feature branches for the versions.

Netlify sites that need to be brought down:

@zacharysarah, @caniszczyk, @squeed, I don't have the Netlify admin permissions to delete these sites, and suspending them isn't an option. Who is the best person to bring down these sites?

@caniszczyk
Copy link

the sites should be deleted :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants