Add Version to CNI interface #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeZappa87
force-pushed
the
feature/addversiontocni
branch
from
27489d1
to
a93f66e
Compare
MikeZappa87
force-pushed
the
feature/addversiontocni
branch
2 times, most recently
from
2271425
to
50d01c4
Compare
|
/assign @squeed |
squeed
approved these changes
Apr 8, 2024
Signed-off-by: Michael Zappa <michael.zappa@gmail.com>
squeed
force-pushed
the
feature/addversiontocni
branch
from
50d01c4
to
dd65e2d
Compare
s1061123
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at how to integrate STATUS/GC in containerd I noticed that Version was not exposed on the CNI Interface. I am not certain if that was intended? I didn't add a test for this yet since it might be intentionally not added. This would be helpful to have in CNI 1.1.