Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rootless handling of /dev/shm size #1595

Closed
wants to merge 1 commit into from
Closed

Fix rootless handling of /dev/shm size #1595

wants to merge 1 commit into from

Conversation

rhatdan
Copy link
Member

@rhatdan rhatdan commented May 16, 2019

Rootless mode was ignoreing the --shm-size option.
For some reason the test that would have caught this was disabled.

Signed-off-by: Daniel J Walsh dwalsh@redhat.com

@rhatdan
Copy link
Member Author

rhatdan commented May 16, 2019

Eventually will fix containers/podman#3134

@rhatdan
Copy link
Member Author

rhatdan commented May 16, 2019

@nalind @giuseppe @vrothberg @TomSweeneyRedHat PTAL

@giuseppe
Copy link
Member

LGTM

vrothberg
vrothberg reviewed May 16, 2019
View reviewed changes
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrothberg
Copy link
Member

@rh-atomic-bot r_

@vrothberg
Copy link
Member

@rh-atomic-bot r+

@rh-atomic-bot
Copy link
Collaborator

📌 Commit 2903396 has been approved by vrothberg

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit 2903396 with merge 9fe252b...

rh-atomic-bot pushed a commit that referenced this pull request May 16, 2019
@rhatdan @rh-atomic-bot
Fix rootless handling of /dev/shm size
9fe252b 
Rootless mode was ignoreing the --shm-size option.
For some reason the test that would have caught this was disabled.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>

Closes: #1595
Approved by: vrothberg
@TomSweeneyRedHat
Copy link
Member

I'll slap on another LGTM before it merges.

@jpic jpic mentioned this pull request May 16, 2019
Open
@rh-atomic-bot
Copy link
Collaborator

💔 Test failed - status-travis

@vrothberg
Copy link
Member

Tests don't look happy: not ok 175 from shm-size test

@jpic
Copy link

jpic commented May 16, 2019

Works here:

jpic@ci:~/mrs$ /home/jpic/buildah/src/github.com/containers/buildah/buildah bud --shm-size 1G --layers .
STEP 1: FROM docker.io/node:10-alpine
STEP 2: RUN df -h
Filesystem                Size      Used Available Use% Mounted on
/dev/md0                233.1G    148.9G     72.3G  67% /
/dev                     64.0M         0     64.0M   0% /dev
/tmp/buildah465903895/shm
                          1.0G         0      1.0G   0% /dev/shm

@jpic jpic mentioned this pull request May 16, 2019
Closed
@rhatdan
Fix rootless handling of /dev/shm size
5530c22 
Rootless mode was ignoreing the --shm-size option.
For some reason the test that would have caught this was disabled.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
@rhatdan
Copy link
Member Author

rhatdan commented May 18, 2019

@rh-atomic-bot r=vrothberg

@rh-atomic-bot
Copy link
Collaborator

📌 Commit 5530c22 has been approved by vrothberg

@rh-atomic-bot
Copy link
Collaborator

⌛ Testing commit 5530c22 with merge 7793c51...

@rh-atomic-bot
Copy link
Collaborator

💔 Test failed - status-travis

@rh-atomic-bot
Copy link
Collaborator

☀️ Test successful - status-papr, status-travis
Approved by: vrothberg
Pushing 7793c51 to master...

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@vrothberg vrothberg vrothberg left review comments

Assignees
No one assigned
Labels
locked - please file new issue/PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@rhatdan @giuseppe @vrothberg @rh-atomic-bot @TomSweeneyRedHat @jpic