buildah build: add --all-platforms #3546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
kind/feature
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
nalind
force-pushed
the
all-the-platform
branch
2 times, most recently
from
4a1192e
to
9f1ce7a
Compare
rhatdan
reviewed
Sep 28, 2021
imagebuildah/build.go
Outdated
| platform := instance.Platform.OS + "/" + instance.Platform.Architecture | ||
| present[platform] = struct{}{} | ||
| if instance.Platform.Variant != "" { | ||
| platform = platform + "/" + instance.Platform.Variant |
There was a problem hiding this comment.
You want to build multiple arches with and without the variant?
nalind
changed the title
nalind
force-pushed
the
all-the-platform
branch
from
9f1ce7a
to
86f9b2e
Compare
nalind
changed the title
nalind
force-pushed
the
all-the-platform
branch
from
86f9b2e
to
cdb623b
Compare
|
LGTM |
nalind
force-pushed
the
all-the-platform
branch
3 times, most recently
from
0a0fb13
to
b1a83bd
Compare
Add a --all-platforms that instructs the builder to build for the intersection of all platforms for which the build's base images are available. Returns an error if any of them aren't references to manifest lists. We've learned that we can't really trust architecture and OS information stored in image config blobs, so we don't try to salvage that case. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
all-the-platform
branch
from
b1a83bd
to
100d5b1
Compare
|
/lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Add a
--all-platformsthat instructs the builder to build for the intersection of all platforms for which the build's base images are available. Returns an error if any of them aren't references to manifest lists. We've learned that we can't really trust architecture and OS information stored in image config blobs, so we don't try to salvage that case.How to verify it
New integration test!
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
The bits where we populate and prune the list of platforms that all of our base images support use versions both with and without variant information in order to avoid dropping 64-bit ARM when one base image is for variant "v8" and one doesn't specify a variant. It's not ideal, but I think it's within the bounds of for how variant information is meant to be treated.
Does this PR introduce a user-facing change?