-
Notifications
You must be signed in to change notification settings - Fork 784
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update buildah-build 'platform' option compatibility notes #3580
docs: update buildah-build 'platform' option compatibility notes #3580
Conversation
Thanks @jayaddison. git commit -a --amend -s LGTM |
Signed-off-by: James Addison <jay@jp-hosting.net>
Commit signed; thanks @rhatdan |
…ty notes Signed-off-by: James Addison <jay@jp-hosting.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
Restarted the flaked job.
/hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jayaddison, TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks @vrothberg @TomSweeneyRedHat! |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Updates the
buildah-build
documentation to clarify that theplatform
option conflicts with theos
/arch
/variant
options.How to verify it
Run a
buildah
v1.19+ container build with bothplatform
andarch
options set (ref: redhat-actions/buildah-build#75)Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?