Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add freebsd cross build targets #4111

Merged
merged 2 commits into from
Jul 15, 2022
Merged

Conversation

dfr
Copy link
Contributor

@dfr dfr commented Jul 14, 2022

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

This should help to keep the freebsd port building.

Does this PR introduce a user-facing change?

None

[NO NEW TESTS NEEDED]

@openshift-ci openshift-ci bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 14, 2022
dfr added 2 commits July 14, 2022 15:49
Not terribly useful in general but the cross build targets include 32bit
architectures

Signed-off-by: Doug Rabson <dfr@rabson.org>
Signed-off-by: Doug Rabson <dfr@rabson.org>
@rhatdan
Copy link
Member

rhatdan commented Jul 15, 2022

LGTM
/approve

Copy link
Collaborator

@flouthoc flouthoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
LGTM

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dfr, flouthoc, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@flouthoc
Copy link
Collaborator

cc @nalind for info

@openshift-ci openshift-ci bot merged commit dc15097 into containers:main Jul 15, 2022
@dfr dfr deleted the freebsd-cross branch August 6, 2022 07:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm locked - please file new issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants