Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable packit builds for centos-stream+epel-next-8 #5493

Merged

Conversation

nalind
Copy link
Member

@nalind nalind commented Apr 30, 2024

What type of PR is this?

/kind failing-test
/kind other

What this PR does / why we need it:

Disable packit builds for centos-stream+epel-next-8. It's no longer one of the active releases for the rhcontainerbot/podman-next COPR at https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/.

Add "adjustments to .packit.yaml" to the list of things we don't require updated tests for.

How to verify it

No EL8-ish packit build results in CI.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/other approved labels Apr 30, 2024
@nalind nalind force-pushed the disable-rhel-8-packit-builds branch from bd32411 to fbe60de Compare April 30, 2024 18:54
@nalind nalind force-pushed the disable-rhel-8-packit-builds branch from fbe60de to e4d4932 Compare April 30, 2024 21:23
It's no longer an active release for the rhcontainerbot/podman-next COPR
at https://copr.fedorainfracloud.org/coprs/rhcontainerbot/podman-next/.

Add "adjustments to .packit.yaml" to the list of things we don't require
updated tests for.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@nalind nalind force-pushed the disable-rhel-8-packit-builds branch from e4d4932 to 7688d88 Compare May 1, 2024 14:37
Copy link
Member

@Luap99 Luap99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@lsm5 PTAL

Copy link
Member

@lsm5 lsm5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @nalind

@openshift-ci openshift-ci bot added the lgtm label May 2, 2024
Copy link
Contributor

openshift-ci bot commented May 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lsm5, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 2227a81 into containers:main May 2, 2024
34 checks passed
@nalind nalind deleted the disable-rhel-8-packit-builds branch May 2, 2024 13:32
@nalind
Copy link
Member Author

nalind commented May 2, 2024

/cherry-pick release-1.35

@openshift-cherrypick-robot

@nalind: #5493 failed to apply on top of branch "release-1.35":

Applying: Disable packit builds for centos-stream+epel-next-8
Using index info to reconstruct a base tree...
M	.packit.yaml
M	tests/validate/pr-should-include-tests
Falling back to patching base and 3-way merge...
Auto-merging tests/validate/pr-should-include-tests
CONFLICT (content): Merge conflict in tests/validate/pr-should-include-tests
Auto-merging .packit.yaml
CONFLICT (content): Merge conflict in .packit.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Disable packit builds for centos-stream+epel-next-8
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/other lgtm locked - please file new issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants