Re-enable two conformance tests #5566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
kind/failing-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Ephemeral COPR build failed. @containers/packit-build please check. |
This looks like the relevant log section: |
nalind
force-pushed
the
conformance-fixups
branch
3 times, most recently
from
a1a6930
to
b20dbf0
Compare
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Pass the test registry password to `docker login` using stdin instead of passing it on the command line. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Check "WORKDIR" both with and without path separators at the end of the instruction argument (e.g. "/foo" and "/foo/"). Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Newer docker build doesn't set it, so we need to stop. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Renovate updated references "FROM centos:7" to "FROM centos:8", but we changed various others references to it to quay.io/libpod/centos:7 some time ago. Update these stragglers. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
The conformance tests use the default temporary directory for storing content when running, and the vfs driver easily needs more than the size of the tmpfs we have on /tmp when we're running conformance tests. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
conformance-fixups
branch
from
b20dbf0
to
8b0ecd7
Compare
|
/lgtm |
openshift-merge-bot
bot
merged commit dd6be38
into
containers:main
35 of 37 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
How to verify it
New conformance tests for the bits we changed in imagebuilder! Also, the ones we already had should all be passing again!
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?