Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-build on Fedora #5572

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

cevich
Copy link
Member

@cevich cevich commented Jun 5, 2024

What type of PR is this?

/kind other

What this PR does / why we need it:

Executing a golang cross-compile on an expensive resource such as a Mac has questionable overall value. Switch to running on a default Fedora VM instead.

How to verify it

The cross_build task will complete without any errors.

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Ref. discussion: #5551 (comment)

Does this PR introduce a user-facing change?

None

Copy link
Contributor

openshift-ci bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cevich

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jun 5, 2024
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

Executing a golang cross-compile on an expensive resource such as a Mac
has questionable overall value.  Switch to running on a default Fedora
VM instead.

Signed-off-by: Chris Evich <cevich@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Jun 5, 2024

LGTM
But do we still get a native MAC Build?

@cevich
Copy link
Member Author

cevich commented Jun 6, 2024

But do we still get a native MAC Build?

I'm unaware of one if it even exists. In #5551 (comment) Nalin indicated it might work, but I'm unsure of how useful it would be. IMHO anyone on a Mac is probably going to do builds using podman-desktop. But I'm no expert, maybe a chroot/VFS image build on a Mac (running a native buildah) might be a nice feature (assuming it doesn't work currently).

@cevich
Copy link
Member Author

cevich commented Jun 6, 2024

Clarification: This PR is simply about saving $$$ 😄

@nalind
Copy link
Member

nalind commented Jun 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jun 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 79b3aca into containers:main Jun 6, 2024
35 of 37 checks passed
@cevich
Copy link
Member Author

cevich commented Jun 7, 2024

/cherry-pick release-1.34

@openshift-cherrypick-robot

@cevich: new pull request created: #5576

In response to this:

/cherry-pick release-1.34

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cevich
Copy link
Member Author

cevich commented Jun 7, 2024

/cherry-pick release-1.33

@openshift-cherrypick-robot

@cevich: new pull request created: #5577

In response to this:

/cherry-pick release-1.33

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cevich
Copy link
Member Author

cevich commented Jun 7, 2024

/cherry-pick release-1.35

@openshift-cherrypick-robot

@cevich: new pull request created: #5578

In response to this:

/cherry-pick release-1.35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cevich
Copy link
Member Author

cevich commented Jun 7, 2024

/cherry-pick release-1.32

@openshift-cherrypick-robot

@cevich: new pull request created: #5579

In response to this:

/cherry-pick release-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cevich
Copy link
Member Author

cevich commented Jun 7, 2024

/cherry-pick release-1.29

@openshift-cherrypick-robot

@cevich: #5572 failed to apply on top of branch "release-1.29":

Applying: Cross-build on Fedora
Using index info to reconstruct a base tree...
M	.cirrus.yml
Falling back to patching base and 3-way merge...
Auto-merging .cirrus.yml
CONFLICT (content): Merge conflict in .cirrus.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Cross-build on Fedora
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stale-locking-app stale-locking-app bot locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants