-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-build on Fedora #5572
Cross-build on Fedora #5572
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cevich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ephemeral COPR build failed. @containers/packit-build please check. |
Executing a golang cross-compile on an expensive resource such as a Mac has questionable overall value. Switch to running on a default Fedora VM instead. Signed-off-by: Chris Evich <cevich@redhat.com>
LGTM |
I'm unaware of one if it even exists. In #5551 (comment) Nalin indicated it might work, but I'm unsure of how useful it would be. IMHO anyone on a Mac is probably going to do builds using podman-desktop. But I'm no expert, maybe a chroot/VFS image build on a Mac (running a native buildah) might be a nice feature (assuming it doesn't work currently). |
Clarification: This PR is simply about saving $$$ 😄 |
/lgtm |
79b3aca
into
containers:main
/cherry-pick release-1.34 |
@cevich: new pull request created: #5576 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.33 |
@cevich: new pull request created: #5577 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.35 |
@cevich: new pull request created: #5578 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.32 |
@cevich: new pull request created: #5579 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.29 |
@cevich: #5572 failed to apply on top of branch "release-1.29":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind other
What this PR does / why we need it:
Executing a golang cross-compile on an expensive resource such as a Mac has questionable overall value. Switch to running on a default Fedora VM instead.
How to verify it
The
cross_build
task will complete without any errors.Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Ref. discussion: #5551 (comment)
Does this PR introduce a user-facing change?