Vendor in latest containers/(common, image, storage) #5585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ephemeral COPR build failed. @containers/packit-build please check. |
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
removed
the
needs-rebase
rhatdan
changed the title
rhatdan
changed the title
|
@giuseppe The pigz change has changed one of the tests when running out of space on disk. [+2438s] # Error: writing blob: storing blob to file "/var/tmp/buildah_tests.fhmvnh/buildah-test/container_images_storage3753737850/2": pigz: skipping: : corrupted -- incomplete deflate data: exit status 1 Where currently Buildah test is looking for: We can simply fix the tests, but the error message from pigz kinda stinks. |
giuseppe
added a commit
to giuseppe/storage
that referenced
this pull request
Jul 11, 2024
if there is an error reading from the input stream, prefer to report it instead of the error from the filter program itself. We have a test in the buildah CI that expects the "no space left on device" error that comes from the input stream, to avoid changing the test, just fix it here. Reported here: containers/buildah#5585 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
this should help: containers/storage#2012 |
giuseppe
added a commit
to giuseppe/storage
that referenced
this pull request
Jul 11, 2024
if there is an error reading from the input stream, prefer to report it instead of the error from the filter program itself. We have a test in the buildah CI that expects the "no space left on device" error that comes from the input stream, to avoid changing the test, just fix it here. Reported here: containers/buildah#5585 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe
added a commit
to giuseppe/storage
that referenced
this pull request
Jul 11, 2024
if there is an error reading from the input stream, prefer to report it instead of the error from the filter program itself. We have a test in the buildah CI that expects the "no space left on device" error that comes from the input stream, to avoid changing the test, just fix it here. Reported here: containers/buildah#5585 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
Testing latest changes in common, storage and image ASAP. Needed to get buildah vendor into Podman to work correctly. Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
|
@giuseppe @mtrmac @cgwalters PTAL |
|
@flouthoc @giuseppe @nalind @mheon @ashley-cui @vrothberg PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, rhatdan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 4a82e0a
into
containers:main
35 of 36 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing latest changes in common, storage and image ASAP.
Needed to get buildah vendor into Podman to work correctly.
Signed-off-by: Daniel J Walsh dwalsh@redhat.com