Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gofix, gofmt the code, add gofmt linter #5680

Merged
merged 2 commits into from
Aug 12, 2024
Merged

gofix, gofmt the code, add gofmt linter #5680

merged 2 commits into from
Aug 12, 2024

Conversation

kolyshkin
Copy link
Contributor

What type of PR is this?

/kind cleanup

@kolyshkin
*: fix build tags
24da188 
This change is generated by `go1.23rc2 fix ./...`.

Had to use go1.23rc2, since all released go versions have a bug
preventing it from working with `go 1.22.0` in go.mod (opened
golang/go#68825,
golang/go#68824 for awareness).

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin
*: use gofmt -s, add gofmt linter
fd3aba9 
1. Use gofmt to format the code:

	git ls-files \*.go | grep -Ev '/?vendor/' | xargs gofmt -w -s

2. Add gofmt to golangci-lint (it's not enabled by default).

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@openshift-ci openshift-ci bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Aug 10, 2024
@packit-as-a-service Packit-as-a-Service
Copy link

We were not able to find or create Copr project packit/containers-buildah-5680 specified in the config with the following error:

Packit received HTTP 500 Internal Server Error from Copr Service. Check the Copr status page: https://copr.fedorainfracloud.org/status/stats/, or ask for help in Fedora Build System matrix channel https://matrix.to/#/#buildsys:fedoraproject.org.

Unless the HTTP status code above is >= 500, please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

@nalind
Copy link
Member

nalind commented Aug 12, 2024

LGTM, thanks!
/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 12, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kolyshkin, nalind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a47263d into containers:main Aug 12, 2024
28 of 36 checks passed
@majamassarini majamassarini mentioned this pull request Aug 14, 2024
Merged
@FrostyX FrostyX mentioned this pull request Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nalind nalind

Labels
approved kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kolyshkin @nalind