Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.55.x][git cherry-pick 5c81adc] apparmor: fix parsing beta/alpha version #1744

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

hswong3i
Copy link

Copied from github.com/moby/moby who already has a fix for it. Tested manually on a Ubuntu 23.10 (beta) VM.

Fixes: #containers/podman/issues/20278

Cherry-pick via v0.55, for CRI-O v1.28.x (see https://github.com/cri-o/cri-o/blob/release-1.28/go.mod#L23)

Copied from github.com/moby/moby who already has a fix for it.
Tested manually on a Ubuntu 23.10 (beta) VM.

Fixes: #containers/podman/issues/20278
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
@rhatdan
Copy link
Member

rhatdan commented Nov 19, 2023

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented Nov 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hswong3i, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 165b7a4 into containers:v0.55 Nov 19, 2023
5 checks passed
@hswong3i
Copy link
Author

Shall we create a hotfix patch release for this, so PR from CRI-O could reference to it?

@hswong3i
Copy link
Author

hswong3i commented Dec 1, 2023

@rhatdan since Kubernetes now coming with https://github.com/kubernetes/kubernetes/releases/tag/v1.29.0-rc.1, so soon we need CRI-O for that accordingly.

Now following PR looks good from CRI-O:

Shall we give a hotfix patch release here, so CRI-O next stable release for Kubernetes v1.29.0 could reference it, rather than referencing a specific GIT commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants