Drop composefs-from-json #226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Larsson <alexl@redhat.com>
This is not needed anymore by podman or the tests, and anyone who needs it could reimplement it outside using the library API. Signed-off-by: Alexander Larsson <alexl@redhat.com>
cgwalters
approved these changes
Oct 26, 2023
|
This would've been a really cool feature for NixOS because we do not have access to actual users (as in entries in/etc/passwd) in the nix-build sandbox but have all the information in Nix (which is easy to convert to json). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the test assed to the dump format (producing identical images) and drops composefs-from-json. This allows us to drop a bunch of dependencies and close some bugs, and also this is not used anymore by podman.