internal: Rewrite byteswapping macros #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgwalters
force-pushed
the
rewrite-lcfs-internal
branch
3 times, most recently
from
35463f6
to
0d69523
Compare
|
Hmm, CI failure here looks maybe like old gcc getting confused by |
The real motivation here is to rewrite the code in order to complete the relicensing, because the person who last touched this didn't respond. And I don't think we need these static assertions; let's just audit the callers to be sure they're passing the right types. Signed-off-by: Colin Walters <walters@verbum.org>
cgwalters
force-pushed
the
rewrite-lcfs-internal
branch
from
0d69523
to
dfe6e66
Compare
|
I rewrote things to just drop the assertions, they aren't that valuable. |
alexlarsson
approved these changes
Oct 2, 2024
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The real motivation here is to rewrite the code in order to complete the relicensing, because the person who last touched this didn't respond.
And in general, using
_Generichere cleans things up anyways.