Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crun should output to log and stderr #102

Closed
crosbymichael opened this issue Sep 20, 2019 · 2 comments · Fixed by #103
Closed

crun should output to log and stderr #102

crosbymichael opened this issue Sep 20, 2019 · 2 comments · Fixed by #103

Comments

@crosbymichael
Copy link
Contributor

Runc logs errors to both, the log file and stderr for errors that are returned via the main() and some programs depend on these error messages.

https://github.com/opencontainers/runc/blob/master/main.go#L156

We should probably do the same in crun.
giuseppe added a commit to giuseppe/crun that referenced this issue Sep 21, 2019
@giuseppe
error: always write errors to stderr
c69fd8f 
make sure errors are always written to stderr, even in case a
different --log=FILE is specified.

Closes: containers#102

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@giuseppe giuseppe mentioned this issue Sep 21, 2019
Merged
@giuseppe
Copy link
Member

@crosbymichael does #103 work for you?

If there is anything in particular you are testing, please let me know and I'll try to integrate it in the CI

giuseppe added a commit to giuseppe/crun that referenced this issue Sep 21, 2019
@giuseppe
error: always write errors to stderr
1dbafb4 
make sure errors are always written to stderr, even in case a
different --log=FILE is specified.

Closes: containers#102

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
giuseppe added a commit to giuseppe/crun that referenced this issue Sep 21, 2019
@giuseppe
error: always write errors to stderr
5a89c3c 
make sure errors are always written to stderr, even in case a
different --log=FILE is specified.

Closes: containers#102

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
@crosbymichael
Copy link
Contributor Author

I'm working through the containerd integration tests to get everything passing. Some changes are required in containerd and some are required here. I'll test #103 today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

error: always write errors to stderr giuseppe/crun
2 participants
@giuseppe @crosbymichael