linux: ignore errors creating /dev/console #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhatdan
reviewed
Oct 29, 2019
| return ret; | ||
| { | ||
| /* Ignore errors if the file creation fails. */ | ||
| crun_error_release (err); |
There was a problem hiding this comment.
Should we check if the file exists? and only ignore those errors?
There was a problem hiding this comment.
sure, changed in the newer version
if the file cannot be created, check if it already exists before raising an error. Closes: containers#150 Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
|
LGTM |
|
@giuseppe I think we need a new release to go out on Friday as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ignore errors if the file cannot be created as it might already
exist. We are anyway going to create a mount on top of it and we'll
catch possible errors during the mount itself.
Closes: #150
Signed-off-by: Giuseppe Scrivano gscrivan@redhat.com