Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

criu: Enable support for restore of shared IPC, UTS and Time namespaces #743

Merged
merged 3 commits into from
Oct 5, 2021

Conversation

rst0git
Copy link
Contributor

@rst0git rst0git commented Oct 1, 2021

This pull request enables restoring of containers with IPC, UTS and Time namespaces.
It requires the criu_join_ns_add API of libcriu, introduced in: checkpoint-restore/criu#1617

src/libcrun/criu.c Outdated Show resolved Hide resolved
Signed-off-by: Radostin Stoyanov <radostin@redhat.com>
@rst0git rst0git force-pushed the criu-join-ns branch 2 times, most recently from c58b989 to 8506ec1 Compare October 5, 2021 10:36
@rst0git rst0git marked this pull request as ready for review October 5, 2021 10:39
When a container config specifies path for an existing namespace,
CRIU should use this namespace during restore.

This patch is make use of the criu_join_ns_add() libcriu API to
specify the shared container namespace to be used on restore.

Signed-off-by: Radostin Stoyanov <radostin@redhat.com>
Signed-off-by: Radostin Stoyanov <radostin@redhat.com>
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants