cgroup: ignore rootless errors if manager != systemd #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giuseppe
force-pushed
the
cgroupfs-ignore-rootless-errors
branch
from
47b1655
to
fa1b6f3
Compare
rhatdan
reviewed
Sep 19, 2019
| @@ -914,8 +914,9 @@ libcrun_cgroup_enter (oci_container_linux_resources *resources, int cgroup_mode, | |||
| return ret; | |||
| } | |||
|
|
|||
| if (rootless > 0 && cgroup_mode != CGROUP_MODE_UNIFIED) | |||
| if (rootless > 0 && (cgroup_mode != CGROUP_MODE_UNIFIED || manager != CGROUP_MANAGER_SYSTEMD)) | |||
There was a problem hiding this comment.
Should we at least log a debug message if manager != SYSTEMD?
There was a problem hiding this comment.
I've added a warning when manager != SYSTEMD and running on cgroups v2
giuseppe
force-pushed
the
cgroupfs-ignore-rootless-errors
branch
from
fa1b6f3
to
986ed08
Compare
on an unified hierarchy ignore cgroups errors if running in a user namespace and the manager != systemd. It is the same behaviour that exists on cgroup v1. The issue caused the default buildah configuration to fail when running as rootless on cgroups v2. Signed-off-by: Giuseppe Scrivano <giuseppe@scrivano.org>
giuseppe
force-pushed
the
cgroupfs-ignore-rootless-errors
branch
from
986ed08
to
164e00b
Compare
|
LGTM |
|
tests are green, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
on an unified hierarchy ignore cgroups errors if running in a user
namespace and the manager != systemd. It is the same behaviour that
exists on cgroup v1.
The issue caused the default buildah configuration to fail when
running as rootless on cgroups v2.
Signed-off-by: Giuseppe Scrivano giuseppe@scrivano.org