Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement pushing to docker: with tags #51

Closed
mtrmac opened this issue Aug 17, 2016 · 2 comments
Closed

Implement pushing to docker: with tags #51

mtrmac opened this issue Aug 17, 2016 · 2 comments

Comments

@mtrmac
Copy link
Collaborator

mtrmac commented Aug 17, 2016

Right now we silently replace it with a digest, which is rather useless. This will need extra logic for v2s1 to either reject pushes with a different tag, or to regenerate the manifest.
@mtrmac mtrmac mentioned this issue Sep 20, 2016
Merged
@mtrmac
Copy link
Collaborator Author

mtrmac commented Nov 2, 2016

(Nowadays we do push to a tag, but we don’t update the tag in s1 manifests (which is #88 ). Most modern tools seem not to care about the tag in the s1 manifest, so this is no longer as urgent.)

@mtrmac mtrmac mentioned this issue Jan 19, 2017
Closed
@mtrmac mtrmac mentioned this issue Mar 7, 2017
Closed
@mtrmac
Copy link
Collaborator Author

mtrmac commented May 10, 2017

Fixed by #88 .

@mtrmac mtrmac closed this as completed May 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mtrmac