If the storage device is not initializing, just try everything #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of what makes this solution performant is we initially just try to initialize storage devices, by initializing driver subsystems: --subsystem-match=module --subsystem-match=block --subsystem-match=virtio --subsystem-match=pci --subsystem-match=nvme there may be some kinds of devices unaccounted for, if this is true, after 8 seconds try and initialize all devices. If such devices want to be performant, ideally the people who encounter this should add the minimal required to this storage specific udev trigger, so their device is included in the targeted storage trigger. Signed-off-by: Eric Curtin <ecurtin@redhat.com>
ericcurtin
requested review from
rhatdan,
dougsland and
masneyb
as code owners
|
Merging... It's currently blocking progress of another PR |
ericcurtin
commented
Dec 1, 2023
| @@ -17,7 +17,7 @@ exec_erofs() { | |||
| "$SKIPCPIO_BIN" "/boot/initramfs-$kver.img" | "$CAT" | cpio -ivd | |||
| popd | |||
| rm -f "/boot/initoverlayfs-$kver.img" | |||
| mkfs.erofs "$erofs_compression" "/boot/initoverlayfs-$kver.img" ${INITRAMFS_DUMP_DIR} | |||
There was a problem hiding this comment.
It may have been this change that was breaking the other PR, we should never have an empty "" string here, no quotes is what works here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of what makes this solution performant is we initially just try to initialize storage devices, by initializing driver subsystems:
--subsystem-match=module --subsystem-match=block
--subsystem-match=virtio --subsystem-match=pci --subsystem-match=nvme
there may be some kinds of devices unaccounted for, if this is true, after 8 seconds try and initialize all devices. If such devices want to be performant, ideally the people who encounter this should add the minimal required to this storage specific udev trigger, so their device is included in the targeted storage trigger.