-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
install: detect where the initramfs exists #43
Conversation
Helps distros which the file is not on /boot dir. Signed-off-by: Douglas Schilling Landgraf <dougsland@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is still failing even on fedora39 with specific /boot, does this PR aims to solve c9s distro with single partition?
The problem does also exist in storage_init
https://pastebin.com/2MaZU0ys
https://github.com/containers/initoverlayfs/blob/main/storage-init.c#L180
We need to find first which
/etc/initoverlayfs.conf is the correct one to boot successfully
Linked PR: https://github.com/coreos/rpm-ostree/pull/4721/files We can use this detection technique for now, but I do wonder if there are more changes, rather than detection, should we have some flag we pass to initoverlayfs-install like, so we call in the other PR like:
with But I'm happy to merge this now if needs be so we can keep moving forward. Just say the word! |
@Yarboa we will get to that bugfix, this is unrelated, it doesn't make that problem worse, but this PR will help continue our rpm-ostree efforts if we merge this... But @dougsland might be just as happy integrating this locally for now... |
Did i get it correct?, Does PR enables rpm-ostree to call inioverlayfs-install during rpm-ostree build? First conversation, mislead me :/
|
@Yarboa yeah this use case is different to a human running executing initoverlayfs-install, this is building the image on the rpm-ostree build server use case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Helps distros which the file is not on /boot dir.