Implement stdin/stdout/stderr redirection support using multiport virtio-console #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Hrica <mhrica@redhat.com>
This makes the device act as a multiport console. This doesn't introduce new functionality, the number of ports remains fixed at 1 port (for the terminal with stdin/stdout). Signed-off-by: Matej Hrica <mhrica@redhat.com>
Signed-off-by: Matej Hrica <mhrica@redhat.com>
This is done by creating a port for each of stdin/stdout/stderr, Each of these ports is multidirectional but we only use one direction. Port 0 must always be a console - this is implied by the specification. Signed-off-by: Matej Hrica <mhrica@redhat.com>
mtjhrc
force-pushed
the
multiport-console-v3
branch
2 times, most recently
from
1cbe806
to
c14f41f
Compare
When we redirect the stdout of the guest it opens the question, where should init/kernel messages (things written to the console) go. It seems to make sense to write it as errors to the log, because for now the only messages that go there are errors. Signed-off-by: Matej Hrica <mhrica@redhat.com>
This works by writing ascii 'ETX' into the guest console on SIGINT. This curently only works when the guest input is redirected (otherwise pressing ^C should work, but SIGINT to the host libkrun process won't work. Furthermore init process needs to fork itself, because pid 1 cannot receive SIGINT signal, unless it instals a handler, but we cannot expect all programs to do that. Signed-off-by: Matej Hrica <mhrica@redhat.com>
We should wait until the output currently in the queue of the guest is written and only then exit the libkrun process. This fixes an issue where you would sometimes not get the full output of a program inside the vm (we would call exit sooner, than we finished all the writes). Signed-off-by: Matej Hrica <mhrica@redhat.com>
mtjhrc
force-pushed
the
multiport-console-v3
branch
from
c14f41f
to
e0bccea
Compare
slp
reviewed
Feb 3, 2024
slp
requested changes
Feb 3, 2024
| @@ -28,6 +29,7 @@ use kbs_types::Tee; | |||
| use crate::device_manager; | |||
| #[cfg(feature = "tee")] | |||
| use crate::resources::TeeConfig; | |||
| use crate::signal_handler::register_sigint_handler; | |||
There was a problem hiding this comment.
Please put the register_sigint_handler import and its uses behind a #[cfg(target_os = "linux")] build-time conditional.
There was a problem hiding this comment.
Sure, but why? Does it use something non portable?
There was a problem hiding this comment.
Oh the whole signal_handler file is not compiled on macOS.
Btw we can add cargo clippy --target aarch64-apple-darwin to the pipeline, which checks against simple issues like this (non existing imports), but this currently generates some warnings, so maybe it can be in another PR.
There was a problem hiding this comment.
Yeah, let's get this one merged first. I'll prepare a new PR setting up the CI for aarch64-apple-darwin.
Signed-off-by: Matej Hrica <mhrica@redhat.com>
slp
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.