Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init: accept arguments from the "args" Field #159

Merged
merged 1 commit into from
Feb 6, 2024
Merged

init: accept arguments from the "args" Field #159

merged 1 commit into from
Feb 6, 2024

Conversation

slp
Copy link
Contributor

@slp slp commented Feb 5, 2024

Podman uses the "args" field to set the executable and the arguments to be run in the container, so parse it if found.

@tylerfanelli
Copy link
Collaborator

If args and Cmd are both present, then config_argv may be overwritten. Is this expected?

@slp
Copy link
Contributor Author

slp commented Feb 5, 2024

If args and Cmd are both present, then config_argv may be overwritten. Is this expected?

Only the first will be used, since both of them set parsed_args = 1.

@slp
init: accept arguments from the "args" Field
ce7fbb4 
Podman uses the "args" field to set the executable and the arguments to
be run in the container, so parse it if found.

Signed-off-by: Sergio Lopez <slp@redhat.com>
@slp slp merged commit d6061c8 into containers:main Feb 6, 2024
4 checks passed
@slp slp deleted the init-parse-args branch February 6, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobinso crobinso Awaiting requested review from crobinso

@tylerfanelli tylerfanelli Awaiting requested review from tylerfanelli tylerfanelli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slp @tylerfanelli