Support none parameter on NETAVARK_FW

[oskarirauta]

Passing environment valuepair NETAVARK_FW=none disables all firewall/portmapper related features leaving configuration of firewall to user.

[Luap99]

Thanks for the PR, to pass CI you have to run cargo fmt to fix formatting issues.

Could you also add a new test file for the none driver in test/ directory?
Something like this should be enough to check

netavark/test/100-bridge-iptables.bats

Lines 10 to 13 in 70eee07

	@test "check iptables driver is in use" {
	RUST_LOG=netavark=info run_netavark --file ${TESTSDIR}/testfiles/simplebridge.json setup $(get_container_netns_path)
	assert "${lines[0]}" "==" "[INFO netavark::firewall] Using iptables firewall driver" "iptables driver is in use"
	}

make sure you set NETAVARK_FW=none

[oskarirauta]

@Luap99
Check if it's ok now..

[Luap99]

looks good, could you squash the commits please.

@mheon PTAL

[oskarirauta]

@Luap99

Unfortunately I do not know how to do it properly- I do know how to rebase, issue is that I should had made the PR some time ago, when we talked about this on issues- now I have synced it- so there's a merge commit in between where I synced it before doing this PR-

It looks a bit like this:

• last mainstream commit before I started working
• my work here
• sync with origin/master
• cargo fmt commit
• remove unnecessary result::
• add firewall none test

So I could squash them to cargo fmt commit, but if I squash to sync commit, or even to my work here-commit, it will be a problem... Any good ideas, except make a new branch? That would be easiest solution for me, but if you know a "magic trick" to make it happen, I am all ears..

[mheon]

LGTM. I do start to wonder if we should add a way for Podman to request a specific driver so it can actually request this on a per-network basis.

[oskarirauta]

@mheon I have already requested it for some time ago.. Until that, I'll go with a wrapper script.

[oskarirauta]

@Luap99

PR has been rebased succesfully to single commit.

[Luap99]

LGTM

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Luap99, oskarirauta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Luap99]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[Luap99]

/lgtm
/hold

[Luap99]

/hold cancel