Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect XDG_CONFIG_HOME when generating systemd unit #477

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Ram-Z
Copy link

@Ram-Z Ram-Z commented Apr 16, 2022

Addresses #307 (comment).

Possibly a better approach would be to let package maintainers install this unit file in /usr/systemd/user, but this would break the "single file" design.

Signed-off-by: Samir Benmendil <me@rmz.io>
Signed-off-by: Samir Benmendil <me@rmz.io>
@muayyad-alsadi
Copy link
Collaborator

I would love if we add --global option as in the referenced comment.
I would love if we keep the sudo in the help.

@Ram-Z
Copy link
Author

Ram-Z commented Apr 17, 2022

I would love if we add --global option as in the referenced comment.

The --global option only makes sense with -a create-unit, I wasn't sure how to introduce it nicely. Happy to take advice on how you'd like this handled.

However, I'm not convinced it should exist at all. podman-compose wants to be rootless, providing an easy way to install the systemd unit to the users home directory only is perfectly fine.

I would love if we keep the sudo in the help.

The point of this MR is to install the user systemd unit in the users home directory where sudo is not needed.

@muayyad-alsadi
Copy link
Collaborator

However, I'm not convinced it should exist at all. podman-compose wants to be rootless, providing an easy way to install the systemd unit to the users home directory only is perfectly fine.

a typical valid use case is to install podman-compose rootful and used rootless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants