Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation for configuration change event #1732

Closed
evidolob opened this issue Mar 17, 2023 · 0 comments · Fixed by #1784
Closed

Add implementation for configuration change event #1732

evidolob opened this issue Mar 17, 2023 · 0 comments · Fixed by #1784
Assignees
@benoitf
Labels
area/extensions 🧩 kind/enhancement ✨ Issue for requesting an improvement

Comments

@evidolob
Copy link
Contributor

Is your enhancement related to a problem? Please describe

Extension API has ConfigurationChangeEvent interface, but API is lacking the method to add listener for that event.

Describe the solution you'd like

Uncomment

podman-desktop/packages/extension-api/src/extension-api.d.ts

Line 443 in d262819

// export const onDidChangeConfiguration: Event<ConfigurationChangeEvent>;
and provide implementation.

Describe alternatives you've considered

No response

Additional context

No response
@evidolob evidolob added kind/enhancement ✨ Issue for requesting an improvement area/extensions 🧩 labels Mar 17, 2023
@benoitf benoitf self-assigned this Mar 17, 2023
@gbraad gbraad mentioned this issue Mar 21, 2023
Closed
benoitf added a commit to benoitf/desktop that referenced this issue Mar 22, 2023
@benoitf
feat(extension-api): add implementation for configuration change event
60c5a39 
fixes containers#1732

Change-Id: Ic9681cad8909ae71a9e547031db1819286979fc7
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
benoitf added a commit to benoitf/desktop that referenced this issue Mar 22, 2023
@benoitf
feat(extension-api): add implementation for configuration change event
9cf22c8 
fixes containers#1732

Change-Id: Ic9681cad8909ae71a9e547031db1819286979fc7
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf mentioned this issue Mar 22, 2023
Merged
benoitf added a commit that referenced this issue Mar 23, 2023
@benoitf
feat(extension-api): add implementation for configuration change event
b58a981 
fixes #1732

Change-Id: Ic9681cad8909ae71a9e547031db1819286979fc7
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benoitf benoitf

Labels
area/extensions 🧩 kind/enhancement ✨ Issue for requesting an improvement
Projects
Podman Desktop Planning
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(extension-api): add implementation for configuration change event benoitf/desktop
2 participants
@benoitf @evidolob