Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove CRC extension from the assembly #1686

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

benoitf
Copy link
Collaborator

@benoitf benoitf commented Mar 14, 2023

What does this PR do?

it has been moved to a separate repository https://github.com/crc-org/crc-extension

Screenshot/screencast of this PR

N/A

What issues does this PR fix or reference?

Fixes #1685

How to test this PR?

Change-Id: Ib3a0ed0bc81a04cba35575a652e1351270d71793

it has been moved to a separate repository https://github.com/crc-org/crc-extension

Change-Id: Ib3a0ed0bc81a04cba35575a652e1351270d71793
Signed-off-by: Florent Benoit <fbenoit@redhat.com>
@benoitf benoitf requested a review from a team as a code owner March 14, 2023 08:29
@benoitf benoitf requested review from vzhukovs, lstocchi, gbraad, evidolob and slemeur and removed request for a team March 14, 2023 08:29
Copy link
Contributor

@lstocchi lstocchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove any reference to CRC - extensions/crc from the doc?

@benoitf
Copy link
Collaborator Author

benoitf commented Mar 14, 2023

the extension is still there (you can install it this is why I kept documentation)

@gbraad
Copy link
Member

gbraad commented Mar 14, 2023

New location for the extension is: https://github.com/crc-org/crc-extension

@gbraad
Copy link
Member

gbraad commented Mar 14, 2023

from the doc?

Extensions will have their own documentation. The documentation in this repo would be more generic in how to enable (discover/find) these extensions. In that case, using OpenShift Local (with microshift) as an example, might not be a bad example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move CRC extension to its own repository
5 participants