fix: use podman machine inspect to know if machine is rootful #7024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in the past, the flag was not exposed so we had to parse some configuration files, but now we should rely on the `podman machine inspect` command to know if it's rootful or rootless fixes containers#7000 Signed-off-by: Florent Benoit <fbenoit@redhat.com>
feloy
approved these changes
Apr 30, 2024
Co-authored-by: Philippe Martin <feloy1@gmail.com> Signed-off-by: Florent BENOIT <fbenoit@redhat.com>
1 task
|
LGTM. Tested with 5.0.2 and 4.9.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
in the past, the flag was not exposed so we had to parse some configuration files, but now we should rely on the
podman machine inspectcommand to know if it's rootful or rootlessScreenshot / video of UI
What issues does this PR fix or reference?
fixes #7000
How to test this PR?
use test case of the linked issue