chore(tests): improve container start up error handling #7283
Conversation
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
| // 2. Opening Containers page with new container on it | ||
| // 3. staying on the run image page with an error | ||
| // 4. Starting a container without entrpoint or command creates a container, but it stays on Run Image Page without error | ||
| if ((await this.errorAlert.count()) > 0 && (await this.name.isVisible())) { |
There was a problem hiding this comment.
just for readability I think it will be easier with intermediate variables
There was a problem hiding this comment.
Yes. I have changed the code a bit, added a wait for page to switch (or not) just to make sure to get right error in the line.
Signed-off-by: Ondrej Dockal <odockal@redhat.com>
| import { BasePage } from './base-page'; | ||
| import { ContainersPage } from './containers-page'; | ||
|
|
||
| export interface ContainerInteractiveParams { |
There was a problem hiding this comment.
This shouldn't be here, it should be moved in one of the other files where interfaces are defined.
There was a problem hiding this comment.
Moved to core folder.
| // 2. Opening Containers page with new container on it | ||
| // 3. staying on the run image page with an error | ||
| // 4. Starting a container without entrypoint or command creates a container, but it stays on Run Image Page without error | ||
| await waitWhile( |
There was a problem hiding this comment.
Why not replace this waitWhile() with await playExpect(this.name).toBeVisible() ? I'm not clear what happens if the field is not visible in your current implementation before the timer runs out, since the error is not propagated, it seems to me that the test would continue even though the field wouldn't be visible.
| @@ -348,7 +355,8 @@ describe.skipIf(process.env.GITHUB_ACTIONS && process.env.RUNNER_OS === 'Linux') | |||
| const runImagePage = await imageDetailsPage.openRunImage(); | |||
| await playExpect(runImagePage.heading).toContainText(backendImage); | |||
| await runImagePage.setCustomPortMapping(`${portsList[i]}:${portsList[i]}`); | |||
| const containersPage = await runImagePage.startContainer(containerNames[i]); | |||
| await runImagePage.startContainer(containerNames[i], containerStartParams); | |||
| const containersPage = new ContainersPage(page); | |||
… outcomes Signed-off-by: Ondrej Dockal <odockal@redhat.com>
What does this PR do?
Improves reporting of the error during container start up in e2e tests.
Screenshot / video of UI
What issues does this PR fix or reference?
#7276
How to test this PR?
If container start up fails in the e2e tests, the error would be thrown.
Quite a lot to set a container to fail, you can add some custom code to mess up container start up ie. in
run-image-page.tsfile, add this into line 85:Then adjust
package.jsonto run only container-smoke test, to make is faster, runyarn test:e2e.Test should fail with assumed error shown in the assertion output.