Bump version to 4.8.0.post1 #347
Conversation
|
is this semver compliant? I fear it would cause issues with rpm builds. Why not bump to v4.8.1 ? |
|
cc @jwhonce |
|
hmm, packit jobs are successful and we get rpms of the form: I'm fine with this change if we can't do |
|
If packit is not complaining, then I think let's leave it at 4.8.0-1. I messed up the pypi release, my bad - will make sure to be more careful in future. |
|
@mgorny ping, will this change be ok for gentoo? |
|
We could make it work on our end but it's "invalid" in the Python world (unless I'm mistaken, PyPI will translate it to |
ack thanks for the input @mgorny . We haven't used the |
Had an issue with the 4.8.0 release on pypi and we can't repush changes with the same version again so need to bump to a minor version to be able to publish on pypi again. Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, umohnani8 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-merge-bot
bot
merged commit 803ea74
into
containers:release-4.8
Had an issue with the 4.8.0 release on pypi and we can't repush changes with the same version again so need to bump to a minor version to be able to publish on pypi again.