Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore proxies from the env vars when using UNIX Domain Sockets #391

Merged
merged 1 commit into from
May 17, 2024

Conversation

eighthave
Copy link
Contributor

closes #390

closes containers#390

Signed-off-by: Hans-Christoph Steiner <hans@eds.org>
Copy link

We were not able to find or create Copr project packit/containers-podman-py-391 specified in the config with the following error:

Cannot create a new Copr project (owner=packit project=containers-podman-py-391 chroots=['centos-stream-10-x86_64', 'centos-stream-9-x86_64']): Response is not in JSON format, there is probably a bug in the API code.

Please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

@eighthave
Copy link
Contributor Author

Looks like the test failures are unrelated to my change.

@rhatdan
Copy link
Member

rhatdan commented May 16, 2024

LGTM
@umohnani8 @jwhonce PTAL

@jwhonce
Copy link
Member

jwhonce commented May 16, 2024

LGTM

@lsm5 Can you help with the centos issues?

@umohnani8 It appears podman-py/pull/374 introduced something that pylint=3.2.0 does not approve.

@inknos
Copy link
Contributor

inknos commented May 17, 2024

This PR looks good to me.

pull/374 introduced something that pylint=3.2.0 does not approve.

Looks like old_toml_file is not defined in all the if/else blocks

@umohnani8
Copy link
Member

LGTM

@lsm5
Copy link
Member

lsm5 commented May 17, 2024

alright, packit failures are resolved.

@lsm5
Copy link
Member

lsm5 commented May 17, 2024

@umohnani8 @jwhonce @inknos unrelated, we should include rhel, centos and fedora testing for PRs with TMT like we do for some other projects.

  • Would make unittest and make integration suffice, or do we need anything else?
  • Do we also need to run podman-py reverse dependency tests on podman repo for every PR? (I think if these can always finish real fast and don't break often, it would be easier to pitch to podman)

@rhatdan
Copy link
Member

rhatdan commented May 17, 2024

/approve
/lgtm

Copy link
Contributor

openshift-ci bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eighthave, rhatdan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit b8d2c87 into containers:main May 17, 2024
11 of 15 checks passed
@eighthave eighthave deleted the issue-390 branch May 18, 2024 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

standard proxy env var break connecting to UNIX Domain Socket
6 participants