Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remote pod create - custom user NS broken #14233

Closed
vrothberg opened this issue May 13, 2022 · 1 comment · Fixed by #14344
Closed

remote pod create - custom user NS broken #14233

vrothberg opened this issue May 13, 2022 · 1 comment · Fixed by #14344
Assignees
@cdoern
Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.

Comments

@vrothberg
Copy link
Member

Is this a BUG REPORT or FEATURE REQUEST? (leave only one on its own line)

/kind bug

Found while working on #14232. --uidmap is broken for remote pod-create.

[+1219s] # # /var/tmp/go/src/github.com/containers/podman/bin/podman-remote --url unix:/tmp/podman_tmp_jS3o pod create --uidmap 0:200000:5000 --name=8d2tIcAaupPxC6SgoQ012U5EcGgW04
[+1219s] # Error: failed to make pod: must provide at least one UID or GID mapping to configure a user namespace

@cdoern, PTAL.
@openshift-ci openshift-ci bot added the kind/bug Categorizes issue or PR as related to a bug. label May 13, 2022
@cdoern
Copy link
Contributor

cdoern commented May 13, 2022

I will fix this today, thanks for catching it

@cdoern cdoern self-assigned this May 13, 2022
@cdoern cdoern mentioned this issue May 13, 2022
Open
@cdoern cdoern mentioned this issue May 24, 2022
Merged
cdoern pushed a commit to cdoern/podman that referenced this issue Jun 1, 2022
@cdoern
podman pod create --uidmap patch
f728b7b 
podmans remote API does not marshal infra's spec due to
the fact that if it did, all of those options would be available to
the users on the command line. This means we need to manually map "backwards"
some container spec items -> pod spec items before calling PodCreate, this was
one of them that was forgotten

resolves containers#14233

Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
Signed-off-by: cdoern <cdoern@redhat.com>
mheon pushed a commit to mheon/libpod that referenced this issue Jun 14, 2022
@mheon
podman pod create --uidmap patch
4c52deb 
podmans remote API does not marshal infra's spec due to
the fact that if it did, all of those options would be available to
the users on the command line. This means we need to manually map "backwards"
some container spec items -> pod spec items before calling PodCreate, this was
one of them that was forgotten

resolves containers#14233

Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
Signed-off-by: cdoern <cdoern@redhat.com>
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cdoern cdoern

Labels
kind/bug Categorizes issue or PR as related to a bug. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

podman pod create --uidmap patch cdoern/podman
2 participants
@vrothberg @cdoern