Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added healthcheck to ps command #11609

Merged
merged 1 commit into from
Sep 24, 2021
Merged

added healthcheck to ps command #11609

merged 1 commit into from
Sep 24, 2021

Conversation

sankalp-r
Copy link
Contributor

@sankalp-r sankalp-r commented Sep 16, 2021 •
edited
Loading

Added health-check status to STATUS field of podman ps command

Fixes #11527

Signed-off-by: Sankalp Rangare sankalprangare786@gmail.com

@mheon
Copy link
Member

mheon commented Sep 16, 2021

Looks like your PR includes a Signed-off-by line, but the commit message does not; can you add one with git commit --amend -s and re-push?

@mheon
Copy link
Member

mheon commented Sep 16, 2021 •
edited
Loading

Edit: sorry, wrong issue - your validation issue does not require Buildah fixes

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 17, 2021

@sankalp-r: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rhatdan
rhatdan reviewed Sep 17, 2021
View reviewed changes
pkg/ps/ps.go
@@ -241,6 +241,11 @@ func ListContainerBatch(rt *libpod.Runtime, ctr *libpod.Container, opts entities
UTS: uts,
}
}

if hc, err := ctr.HealthCheckStatus(); err == nil {
ps.Status = hc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should at least warn on error.

Copy link
Contributor Author

@sankalp-r sankalp-r Sep 24, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a warning-log changes "ps" command output, which results in failure of other tests.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then at least add it to Debug.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added debug-log.

@rhatdan
Copy link
Member

rhatdan commented Sep 17, 2021

Could you add a test, Probbaly just enhance one of the health check tests to see if you field shows up.

@TomSweeneyRedHat
Copy link
Member

Other than prior comments, changes LGTM

@sankalp-r
added healthcheck to ps command
1e0039a 
Signed-off-by: Sankalp Rangare <sankalprangare786@gmail.com>
@TomSweeneyRedHat
Copy link
Member

I've rerun the fedora-34 root host test, it looked like a flake.

@rhatdan
Copy link
Member

rhatdan commented Sep 24, 2021

/approve
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhatdan, sankalp-r

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 24, 2021
@rhatdan
Copy link
Member

rhatdan commented Sep 24, 2021

Thanks @sankalp-r

@openshift-merge-robot openshift-merge-robot merged commit e19a09c into containers:main Sep 24, 2021
@edsantiago edsantiago mentioned this pull request Oct 4, 2021
Closed
@edsantiago edsantiago mentioned this pull request Oct 19, 2021
Open
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 22, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhatdan rhatdan Awaiting requested review from rhatdan

Assignees

@rhatdan rhatdan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

healthcheck status should be suffix to podman ps status field
5 participants
@sankalp-r @mheon @rhatdan @TomSweeneyRedHat @openshift-merge-robot