Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI:DOCS] Update "CONTRIBUTING" file with Debian/Ubuntu dependencies" #15394

Merged
merged 1 commit into from
Aug 22, 2022
Merged

[CI:DOCS] Update "CONTRIBUTING" file with Debian/Ubuntu dependencies" #15394

merged 1 commit into from
Aug 22, 2022

Conversation

daniloglima
Copy link
Contributor

@daniloglima daniloglima commented Aug 20, 2022

Signed-off-by: Danilo Lima danilo.glima@outlook.com

Does this PR introduce a user-facing change?

None

@openshift-ci openshift-ci bot added do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None release-note-none and removed do-not-merge/release-note-label-needed Enforce release-note requirement, even if just None labels Aug 20, 2022
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@siretart @giuseppe PTAL

@vrothberg
Copy link
Member

Can you rebase to the latest head? That will pull in fixes to let the tests pass.

@vrothberg vrothberg changed the title Update "CONTRIBUTING" file with Debian/Ubuntu dependencies" [CI:DOCS] Update "CONTRIBUTING" file with Debian/Ubuntu dependencies" Aug 22, 2022
Signed-off-by: Danilo Lima <danilo.glima@outlook.com>
@daniloglima
Copy link
Contributor Author

Can you rebase to the latest head? That will pull in fixes to let the tests pass.

Done

@daniloglima daniloglima requested review from vrothberg and removed request for giuseppe August 22, 2022 12:24
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@containers/podman-maintainers PTAL

@mheon
Copy link
Member

mheon commented Aug 22, 2022

/lgtm

@mheon
Copy link
Member

mheon commented Aug 22, 2022

/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: daniloglima, mheon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2022
@openshift-merge-robot openshift-merge-robot merged commit ad359f6 into containers:main Aug 22, 2022
@github-actions github-actions bot added the locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. label Sep 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. locked - please file new issue/PR Assist humans wanting to comment on an old issue or PR with locked comments. release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants